diff options
| author | Harsh Prateek Bora <harsh@linux.vnet.ibm.com> | 2012-07-18 15:15:58 +0530 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2012-07-19 11:34:32 +0100 |
| commit | 88affa1c77c9019f3450f851495997897bd14e40 (patch) | |
| tree | cca448b2547745eefd9cc074be354afbf4ae5135 /trace/simple.h | |
| parent | 794b1f962eb3b1ceb6bbb98dd7a57f62fc0fbc11 (diff) | |
monitor: remove unused do_info_trace
Going forward with simpletrace v2 variable size trace records, we cannot
have a generic function to print trace event info and therefore this
interface becomes invalid.
As per Stefan Hajnoczi:
"This command is only available from the human monitor. It's not very
useful because it historically hasn't been able to pretty-print events
or show them in the right order (we use a ringbuffer but it prints
them out from index 0).
Therefore, I don't think we're under any obligation to keep this
command around. No one has complained about it's limitations - I
think this is a sign that no one has used it. I'd be okay with a
patch that removes it."
Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'trace/simple.h')
| -rw-r--r-- | trace/simple.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/trace/simple.h b/trace/simple.h index 466e75b4ff..6b5358c9f2 100644 --- a/trace/simple.h +++ b/trace/simple.h @@ -29,7 +29,6 @@ void trace3(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3); void trace4(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4); void trace5(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4, uint64_t x5); void trace6(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4, uint64_t x5, uint64_t x6); -void st_print_trace(FILE *stream, fprintf_function stream_printf); void st_print_trace_file_status(FILE *stream, fprintf_function stream_printf); void st_set_trace_file_enabled(bool enable); bool st_set_trace_file(const char *file); |