aboutsummaryrefslogtreecommitdiff
path: root/trace/ftrace.h
diff options
context:
space:
mode:
authorStratos Psomadakis <psomas@grnet.gr>2014-09-15 15:34:57 +0300
committerLuiz Capitulino <lcapitulino@redhat.com>2014-09-26 13:14:10 -0400
commite5554e2015f8fb452135f7b1ce1976536266379c (patch)
treefdc653f3d8f94477ee25b3cb1c4779dabe8c1426 /trace/ftrace.h
parent81ab11a7a524d12412a59ef49c6b270671e62ea0 (diff)
monitor: Reset HMP mon->rs in CHR_EVENT_OPEN
Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in the way the HMP monitor handles its command buffer. When a client closes the connection to the monitor, tcp_chr_read() will detect the G_IO_HUP condition and call tcp_chr_disconnect() to close the server-side connection too. Due to the fact that monitor reads 1 byte at a time (for each tcp_chr_read()), the monitor readline state / buffers might contain junk (i.e. a half-finished command). Thus, without calling readline_restart() on mon->rs in CHR_EVENT_OPEN, future HMP commands will fail. Signed-off-by: Stratos Psomadakis <psomas@grnet.gr> Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'trace/ftrace.h')
0 files changed, 0 insertions, 0 deletions