diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2018-02-01 16:26:25 +0000 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2018-02-19 13:09:44 +0000 |
| commit | 7f1d87ab0fd94cef5086e2879716958303281054 (patch) | |
| tree | 4eb3dc2ab1adf6765997ee94f8a9d4bba871f0f9 /trace-events | |
| parent | 61b01bbc6c27f06f4732aedcb6554e135f41b760 (diff) | |
trace: avoid SystemTap "char const" warnings
SystemTap's dtrace(1) produces the following warning when it encounters
"char const" instead of "const char":
Warning: /usr/bin/dtrace:trace-dtrace-root.dtrace:66: syntax error near:
probe flatview_destroy_rcu
Warning: Proceeding as if --no-pyparsing was given.
This is a limitation in current SystemTap releases. I have sent a patch
upstream to accept "char const" since it is valid C:
https://sourceware.org/ml/systemtap/2018-q1/msg00017.html
In QEMU we still wish to avoid warnings in the current SystemTap
release. It's simple enough to replace "char const" with "const char".
I'm not changing the documentation or implementing checks to prevent
this from occurring again in the future. The next release of SystemTap
will hopefully resolve this issue.
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 20180201162625.4276-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'trace-events')
| -rw-r--r-- | trace-events | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/trace-events b/trace-events index ec95e67089..89fcad0fd1 100644 --- a/trace-events +++ b/trace-events @@ -73,13 +73,13 @@ flatview_destroy(FlatView *view, MemoryRegion *root) "%p (root %p)" flatview_destroy_rcu(FlatView *view, MemoryRegion *root) "%p (root %p)" # gdbstub.c -gdbstub_op_start(char const *device) "Starting gdbstub using device %s" +gdbstub_op_start(const char *device) "Starting gdbstub using device %s" gdbstub_op_exiting(uint8_t code) "notifying exit with code=0x%02x" gdbstub_op_continue(void) "Continuing all CPUs" gdbstub_op_continue_cpu(int cpu_index) "Continuing CPU %d" gdbstub_op_stepping(int cpu_index) "Stepping CPU %d" -gdbstub_op_extra_info(char const *info) "Thread extra info: %s" -gdbstub_hit_watchpoint(char const *type, int cpu_gdb_index, uint64_t vaddr) "Watchpoint hit, type=\"%s\" cpu=%d, vaddr=0x%" PRIx64 "" +gdbstub_op_extra_info(const char *info) "Thread extra info: %s" +gdbstub_hit_watchpoint(const char *type, int cpu_gdb_index, uint64_t vaddr) "Watchpoint hit, type=\"%s\" cpu=%d, vaddr=0x%" PRIx64 "" gdbstub_hit_internal_error(void) "RUN_STATE_INTERNAL_ERROR" gdbstub_hit_break(void) "RUN_STATE_DEBUG" gdbstub_hit_paused(void) "RUN_STATE_PAUSED" @@ -87,9 +87,9 @@ gdbstub_hit_shutdown(void) "RUN_STATE_SHUTDOWN" gdbstub_hit_io_error(void) "RUN_STATE_IO_ERROR" gdbstub_hit_watchdog(void) "RUN_STATE_WATCHDOG" gdbstub_hit_unknown(int state) "Unknown run state=0x%x" -gdbstub_io_reply(char const *message) "Sent: %s" -gdbstub_io_binaryreply(size_t ofs, char const *line) "0x%04zx: %s" -gdbstub_io_command(char const *command) "Received: %s" +gdbstub_io_reply(const char *message) "Sent: %s" +gdbstub_io_binaryreply(size_t ofs, const char *line) "0x%04zx: %s" +gdbstub_io_command(const char *command) "Received: %s" gdbstub_io_got_ack(void) "Got ACK" gdbstub_io_got_unexpected(uint8_t ch) "Got 0x%02x when expecting ACK/NACK" gdbstub_err_got_nack(void) "Got NACK, retransmitting" |