diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2022-04-17 11:29:47 -0700 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2022-04-20 10:51:11 -0700 |
| commit | c60f599bcb9bf9256eb87c1c60add55d23f76de3 (patch) | |
| tree | 826787db9c46fdd8c85f1e766e789ae186312e23 /tests | |
| parent | c59fe6e536adfb2d6f3410f19d592496933f68de (diff) | |
util/log: Rename qemu_log_lock to qemu_log_trylock
This function can fail, which makes it more like ftrylockfile
or pthread_mutex_trylock than flockfile or pthread_mutex_lock,
so rename it.
To closer match the other trylock functions, release rcu_read_lock
along the failure path, so that qemu_log_unlock need not be called
on failure.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220417183019.755276-8-richard.henderson@linaro.org>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/test-logging.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unit/test-logging.c b/tests/unit/test-logging.c index d071400ebc..4c595356ae 100644 --- a/tests/unit/test-logging.c +++ b/tests/unit/test-logging.c @@ -162,7 +162,7 @@ static void test_logfile_lock(gconstpointer data) * our handle remains valid for use due to RCU. */ qemu_set_log_filename(file_path, &error_abort); - logfile = qemu_log_lock(); + logfile = qemu_log_trylock(); g_assert(logfile); fprintf(logfile, "%s 1st write to file\n", __func__); fflush(logfile); |