diff options
author | Eduardo Habkost <ehabkost@redhat.com> | 2019-10-16 16:24:21 -0300 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2019-11-05 16:35:06 +0100 |
commit | 60d3af55da14982b8d1ee3ace7fc48246140721f (patch) | |
tree | c446eafb8851e9f728c1bf004915c90353f89c7e /tests | |
parent | 36609b4fa36f0ac934874371874416f7533a5408 (diff) |
image-fuzzer: Open image files in binary mode
This probably never caused problems because on Linux there's no
actual newline conversion happening, but on Python 3 the
binary/text distinction is stronger and we must explicitly open
the image file in binary mode.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20191016192430.25098-2-ehabkost@redhat.com
Message-Id: <20191016192430.25098-2-ehabkost@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/image-fuzzer/qcow2/layout.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py index 675877da96..c57418fa15 100644 --- a/tests/image-fuzzer/qcow2/layout.py +++ b/tests/image-fuzzer/qcow2/layout.py @@ -503,7 +503,7 @@ class Image(object): def write(self, filename): """Write an entire image to the file.""" - image_file = open(filename, 'w') + image_file = open(filename, 'wb') for field in self: image_file.seek(field.offset) image_file.write(struct.pack(field.fmt, field.value)) |