aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2020-04-15 09:49:22 +0200
committerMarkus Armbruster <armbru@redhat.com>2020-04-29 08:01:51 +0200
commit80a94855737622436a9b5cd25315b9c80d7e3ffa (patch)
tree79bf448d7dbb75080d05f94988181b3163943fbf /tests
parent933d1527785fe839300459abb486905094d192a7 (diff)
qemu-option: Fix has_help_option()'s sloppy parsing
has_help_option() uses its own parser. It's inconsistent with qemu_opts_parse(), as demonstrated by test-qemu-opts case /qemu-opts/has_help_option. Fix by reusing the common parser. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20200415074927.19897-5-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/test-qemu-opts.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c
index 8ff97268d8..77c944c4aa 100644
--- a/tests/test-qemu-opts.c
+++ b/tests/test-qemu-opts.c
@@ -749,8 +749,8 @@ static void test_has_help_option(void)
{ "a=0,?,b", true, true, true },
{ "help,b=1", true, true, false },
{ "?,b=1", true, true, false },
- { "a,b,,help", false /* BUG */, true, true },
- { "a,b,,?", false /* BUG */, true, true },
+ { "a,b,,help", true, true, true },
+ { "a,b,,?", true, true, true },
};
int i;
QemuOpts *opts;