diff options
| author | Michael Roth <mdroth@linux.vnet.ibm.com> | 2012-04-30 09:33:30 -0500 |
|---|---|---|
| committer | Andreas Färber <afaerber@suse.de> | 2012-06-08 16:11:14 +0200 |
| commit | 173bbb754f53e8bfc8e4d488f2ed66fe1072ed69 (patch) | |
| tree | d807452d835e39e512a5784c1f773b877fbe4a6b /tests | |
| parent | 2d496105397b8eca905f9a53c40e2faaac7bfa6b (diff) | |
qapi: String visitor, use %f representation for floats
Currently string-output-visitor formats floats as %g, which is nice in
that trailing 0's are automatically truncated, but otherwise this causes
some issues:
- it uses 6 significant figures instead of 6 decimal places, which
means something like 155777.5 (which even has an exact floating point
representation) will be rounded to 155778 when converted to a string.
- output will be presented in scientific notation when the normalized
form requires a 10^x multiplier. Not a huge deal, but arguably less
readable for command-line arguments.
- due to using scientific notation for numbers requiring more than 6
significant figures, instead of hard-defined decimal places, it
fails a lot of the test-visitor-serialization unit tests for floats.
Instead, let's just use %f, which is what the QJSON and the QMP visitors
use.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-string-output-visitor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test-string-output-visitor.c b/tests/test-string-output-visitor.c index 22909b84ef..608f14a5de 100644 --- a/tests/test-string-output-visitor.c +++ b/tests/test-string-output-visitor.c @@ -84,7 +84,7 @@ static void test_visitor_out_number(TestOutputVisitorData *data, str = string_output_get_string(data->sov); g_assert(str != NULL); - g_assert_cmpstr(str, ==, "3.14"); + g_assert_cmpstr(str, ==, "3.140000"); g_free(str); } |