diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-11-22 08:24:54 +0100 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2023-12-20 10:29:23 +0100 |
| commit | c363764a6048f64d11c6cabf180154cf6f13ac3a (patch) | |
| tree | e04cccb64f5269f2be4f9fed6ddf064d41456fb1 /tests/unit | |
| parent | 71dc6ca2a8fa0eca8ab8e87e6a55cb0114fa4c85 (diff) | |
tests/unit/test-qmp-event: Drop superfluous mutex
Mutex @test_event_lock is held from fixture setup to teardown,
protecting global variable @test_event_data. But tests always run one
after the other, so this is superfluous. It also confuses Coverity.
Drop the mutex.
Fixes: CID 1527425
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231122072456.2518816-2-armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/test-qmp-event.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/tests/unit/test-qmp-event.c b/tests/unit/test-qmp-event.c index 3626d2372f..c2c44687d5 100644 --- a/tests/unit/test-qmp-event.c +++ b/tests/unit/test-qmp-event.c @@ -30,7 +30,6 @@ typedef struct TestEventData { } TestEventData; TestEventData *test_event_data; -static GMutex test_event_lock; void test_qapi_event_emit(test_QAPIEvent event, QDict *d) { @@ -59,9 +58,6 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d) static void event_prepare(TestEventData *data, const void *unused) { - /* Global variable test_event_data was used to pass the expectation, so - test cases can't be executed at same time. */ - g_mutex_lock(&test_event_lock); test_event_data = data; } @@ -69,7 +65,6 @@ static void event_teardown(TestEventData *data, const void *unused) { test_event_data = NULL; - g_mutex_unlock(&test_event_lock); } static void event_test_add(const char *testpath, |