diff options
| author | Emanuele Giuseppe Esposito <eesposit@redhat.com> | 2022-09-26 05:32:14 -0400 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2022-10-07 12:11:41 +0200 |
| commit | 9bd4d3c2e3d2e1df979e818ff0a5c05ca455721a (patch) | |
| tree | 81fae12a51f7c72ea040728599b797ce3091c230 /tests/unit | |
| parent | ba6a91005270c8e199d739c2e2afb49372ba0f7f (diff) | |
job: remove unused functions
These public functions are not used anywhere, thus can be dropped.
Also, since this is the final job API that doesn't use AioContext
lock and replaces it with job_lock, adjust all remaining function
documentation to clearly specify if the job lock is taken or not.
Also document the locking requirements for a few functions
where the second version is not removed.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20220926093214.506243-22-eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/test-blockjob.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/unit/test-blockjob.c b/tests/unit/test-blockjob.c index f88e10e356..c0426bd10c 100644 --- a/tests/unit/test-blockjob.c +++ b/tests/unit/test-blockjob.c @@ -432,7 +432,7 @@ static const BlockJobDriver test_yielding_driver = { }; /* - * Test that job_complete() works even on jobs that are in a paused + * Test that job_complete_locked() works even on jobs that are in a paused * state (i.e., STANDBY). * * To do this, run YieldingJob in an IO thread, get it into the READY @@ -440,7 +440,7 @@ static const BlockJobDriver test_yielding_driver = { * acquire the context so the job will not be entered and will thus * remain on STANDBY. * - * job_complete() should still work without error. + * job_complete_locked() should still work without error. * * Note that on the QMP interface, it is impossible to lock an IO * thread before a drained section ends. In practice, the |