aboutsummaryrefslogtreecommitdiff
path: root/tests/test-qobject-output-visitor.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2018-08-21 14:05:16 -0500
committerThomas Huth <thuth@redhat.com>2018-08-31 09:53:09 +0200
commitb8e1f74b0a258db394a35272a44d14ec0b6e0be9 (patch)
treeeb7bec2a87cff4ad05a6362338c6933cb6128cd7 /tests/test-qobject-output-visitor.c
parentd18572dd9a4ee3f66d205912edae4d87a58ec11f (diff)
tests/libqos: Utilize newer glib spawn check
During development, I got a 'make check' failure that claimed: qemu-img returned status code 32512 ** ERROR:tests/libqos/libqos.c:202:mkimg: assertion failed: (!rc) But 32512 is too big for a normal exit status value, which means we failed to use WEXITSTATUS() to shift the bits to the desired value for printing. However, instead of worrying about how to portably parse g_spawn()'s rc in the proper platform-dependent manner, it's better to just rely on the fact that we now require glib 2.40 (since commit e7b3af815) and can therefore use glib's portable checker instead, where the message under my same condition improves to: Child process exited with code 127 ** ERROR:tests/libqos/libqos.c:192:mkimg: assertion failed: (ret && !err) Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/test-qobject-output-visitor.c')
0 files changed, 0 insertions, 0 deletions