diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2018-11-15 11:46:16 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2018-11-15 13:06:40 +0000 |
| commit | bba390cb9ee31195f4b5d5b061831f5ca37614e2 (patch) | |
| tree | d9cfc8dc12d05d443382220ed0339d96f4c5de68 /tests/test-qmp-event.c | |
| parent | 3fccd3f26ef3c0c76a06c138b17af6d55a5d9904 (diff) | |
linux-user/sparc/signal.c: Remove dead code
Coverity complains (CID 1390847) about some dead code in
do_sigreturn(). This is an if (err) clause that can never be
true, copied from the kernel (where __get_user returns an error).
The one code path that could report an error is in the
currently commented-out pseudocode for handling FPU register
restoring, so move the if into that comment (and fix the
broken indent in the comment in the process).
(The new position for the error check is also the semantically
correct one -- we should not restore the signal mask from
the signal frame if we get an error here, so the check must
be done before set_sigmask(), not after.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-id: 20181115114616.26265-1-peter.maydell@linaro.org
Diffstat (limited to 'tests/test-qmp-event.c')
0 files changed, 0 insertions, 0 deletions