diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-09-02 10:07:57 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2020-09-03 12:47:33 +0200 |
| commit | 978382b453b0e40cc17a983b8c1676386fd3cc5e (patch) | |
| tree | 67e59816540b657aa9fb40768bdff073b7abc096 /tests/qtest | |
| parent | ed943cc934a82fd78102f0df2084a8f3c556716f (diff) | |
tests/qtest/ipmi-kcs: Fix assert side-effect
Fix assert side-effect reported by Coverity:
/qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf()
83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
>>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT)
>>> Argument "--count" of g_assert() has a side effect. The containing function might work differently in a non-debug build.
84 g_assert(--count != 0);
Reported-by: Coverity (CID 1432368)
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200902080801.160652-2-philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/qtest')
| -rw-r--r-- | tests/qtest/ipmi-kcs-test.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c index 693a6aacb5..fc0a918c8d 100644 --- a/tests/qtest/ipmi-kcs-test.c +++ b/tests/qtest/ipmi-kcs-test.c @@ -81,7 +81,8 @@ static void kcs_wait_obf(void) { unsigned int count = 1000; while (IPMI_KCS_CMDREG_GET_OBF() == 0) { - g_assert(--count != 0); + --count; + g_assert(count != 0); } } |