diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-09-02 10:05:52 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2020-09-03 12:47:33 +0200 |
| commit | df1a312fea58bb3f83b5d7eba0946d43cb16675f (patch) | |
| tree | afe1d6c67280f8071813886c3ca0ab4e995e76c9 /tests/qtest | |
| parent | 0bc6746e855621398940b51d9bae1827026ea672 (diff) | |
tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS)
Fix an error handling issue reported by Coverity:
/qemu/tests/qtest/ahci-test.c: 1452 in prepare_iso()
1444 int fd = mkstemp(cdrom_path);
>>> CID 1432375: Error handling issues (NEGATIVE_RETURNS)
>>> "fd" is passed to a parameter that cannot be negative.
1452 ret = write(fd, patt, size);
Reported-by: Coverity (CID 1432375)
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200902080552.159806-1-philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/qtest')
| -rw-r--r-- | tests/qtest/ahci-test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c index ca4294f44f..5e1954852e 100644 --- a/tests/qtest/ahci-test.c +++ b/tests/qtest/ahci-test.c @@ -1443,6 +1443,7 @@ static int prepare_iso(size_t size, unsigned char **buf, char **name) ssize_t ret; int fd = mkstemp(cdrom_path); + g_assert(fd != -1); g_assert(buf); g_assert(name); patt = g_malloc(size); |