aboutsummaryrefslogtreecommitdiff
path: root/tests/qemu-iotests/iotests.py
diff options
context:
space:
mode:
authorNir Soffer <nirsof@gmail.com>2020-08-29 02:21:50 +0300
committerMax Reitz <mreitz@redhat.com>2020-09-15 11:05:12 +0200
commita242b19e80faa95fd5856fca2d4115e853d465b1 (patch)
treeed2f7f4a0535e15efd84b1aae5c99177e605d6b8 /tests/qemu-iotests/iotests.py
parentf765af87c203723f77da37716a74f0eca99f192c (diff)
qemu-iotests: Support varargs syntax in FilePaths
Accept variable number of names instead of a sequence: with FilePaths("a", "b", "c") as (a, b, c): The disadvantage is that base_dir must be used as kwarg: with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2): But this is more clear and calling optional argument as positional arguments is bad idea anyway. Signed-off-by: Nir Soffer <nsoffer@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Message-Id: <20200828232152.205833-4-nsoffer@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/iotests.py')
-rw-r--r--tests/qemu-iotests/iotests.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index bbe63a6da0..635ec99431 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -455,7 +455,7 @@ class FilePaths:
Example usage:
- with FilePaths(['a.img', 'b.img']) as (img_a, img_b):
+ with FilePaths('a.img', 'b.img') as (img_a, img_b):
# Use img_a and img_b here...
# a.img and b.img are automatically removed here.
@@ -463,10 +463,10 @@ class FilePaths:
By default images are created in iotests.test_dir. To create sockets use
iotests.sock_dir:
- with FilePaths(['a.sock'], base_dir=iotests.sock_dir) as (sock,):
+ with FilePaths('a.sock', base_dir=iotests.sock_dir) as (sock,):
"""
- def __init__(self, names, base_dir=test_dir):
+ def __init__(self, *names, base_dir=test_dir):
self.paths = []
for name in names:
self.paths.append(os.path.join(base_dir, file_pattern(name)))
@@ -487,7 +487,7 @@ class FilePath(FilePaths):
FilePath is a specialization of FilePaths that takes a single filename.
"""
def __init__(self, name, base_dir=test_dir):
- super(FilePath, self).__init__([name], base_dir)
+ super(FilePath, self).__init__(name, base_dir=base_dir)
def __enter__(self):
return self.paths[0]