diff options
| author | Alberto Garcia <berto@igalia.com> | 2019-10-14 11:15:45 +0300 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2019-10-14 17:12:48 +0200 |
| commit | f2208fdc5ba2f4d0cbc023e2530b5e3e110d71c2 (patch) | |
| tree | b182d432c52849da44e25597a2ffbfbd374b4908 /tests/qemu-iotests/group | |
| parent | e4ec5ad464e48ab8d978b4dd8aacd05c1c4a87cc (diff) | |
block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK
The BDRV_REQ_NO_FALLBACK flag means that an operation should only be
performed if it can be offloaded or otherwise performed efficiently.
However a misaligned write request requires a RMW so we should return
an error and let the caller decide how to proceed.
This hits an assertion since commit c8bb23cbdb if the required
alignment is larger than the cluster size:
qemu-img create -f qcow2 -o cluster_size=2k img.qcow2 4G
qemu-io -c "open -o driver=qcow2,file.align=4k blkdebug::img.qcow2" \
-c 'write 0 512'
qemu-io: block/io.c:1127: bdrv_driver_pwritev: Assertion `!(flags & BDRV_REQ_NO_FALLBACK)' failed.
Aborted
The reason is that when writing to an unallocated cluster we try to
skip the copy-on-write part and zeroize it using BDRV_REQ_NO_FALLBACK
instead, resulting in a write request that is too small (2KB cluster
size vs 4KB required alignment).
Signed-off-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/group')
| -rw-r--r-- | tests/qemu-iotests/group | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 5805a79d9e..4c861f7eed 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -278,3 +278,4 @@ 265 rw auto quick 266 rw quick 267 rw auto quick snapshot +268 rw auto quick |