diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2020-10-07 06:43:03 -0400 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2020-10-12 11:50:50 -0400 |
| commit | d8a18da56df93b7f778fb97ba370031597d19ffd (patch) | |
| tree | 0a874d0cc3a6f1ffc90b3c1a34f96123e5e2af83 /tests/qemu-iotests/group | |
| parent | 9a613ddccce125e4cc3a4a23c294837c906440d6 (diff) | |
qemu-iotests, qtest: rewrite test 067 as a qtest
Test 067 from qemu-iotests is executing QMP commands to hotplug
and hot-unplug disks, devices and blockdevs. Because the power
of the text-based test harness is limited, it is actually limiting
the checks that it does, for example by skipping DEVICE_DELETED
events.
tests/qtest already has a similar test, drive_del-test.c.
We can merge them, and even reuse some of the existing code in
drive_del-test.c. This will improve the quality of the test by
covering DEVICE_DELETED events and testing multiple architectures
(therefore covering multiple PCI hotplug mechanisms as well as s390x
virtio-ccw).
The only difference is that the new test will always use null-co:// for
the medium rather than qcow2 or raw, but this should be irrelevant for
what the test is covering. For example there are no "qemu-img check"
runs in 067 that would check that the file is properly closed.
The new tests requires PCI hot-plug support, so drive_del-test
is moved from qemu-system-ppc to qemu-system-ppc64.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/group')
| -rw-r--r-- | tests/qemu-iotests/group | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 9e4f7c0153..3432989283 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -88,7 +88,7 @@ 064 rw quick 065 rw quick 066 rw auto quick -067 rw quick +# 067 was removed, do not reuse 068 rw quick 069 rw auto quick 070 rw quick |