diff options
| author | Eric Blake <eblake@redhat.com> | 2018-11-16 15:50:02 -0600 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2018-11-19 11:16:46 -0600 |
| commit | 8cedcffdc195bc39aeb1373826ba0a45629741e0 (patch) | |
| tree | 46509d211d6dcf12f6d2923e9a37a1667177f762 /tests/qemu-iotests/142 | |
| parent | bb39c47d70e84acf5066f79eba27ae5945b837be (diff) | |
iotests: Drop use of bash keyword 'function'
Bash allows functions to be declared with or without the leading
keyword 'function'; but including the keyword does not comply with
POSIX syntax, and is confusing to ksh users where the use of the
keyword changes the scoping rules for functions. Stick to the
POSIX form through iotests.
Done mechanically with:
sed -i 's/^function //' $(git ls-files tests/qemu-iotests)
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181116215002.2124581-1-eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/142')
| -rwxr-xr-x | tests/qemu-iotests/142 | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/qemu-iotests/142 b/tests/qemu-iotests/142 index c7c360d11b..5fc488f5d2 100755 --- a/tests/qemu-iotests/142 +++ b/tests/qemu-iotests/142 @@ -45,7 +45,7 @@ _supported_os Linux _default_cache_mode none _supported_cache_modes none directsync -function do_run_qemu() +do_run_qemu() { echo Testing: "$@" ( @@ -59,7 +59,7 @@ function do_run_qemu() echo } -function run_qemu() +run_qemu() { do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp } @@ -88,7 +88,7 @@ echo files="if=none,file=$TEST_IMG,backing.file.filename=$TEST_IMG.base" ids="node-name=image,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file" -function check_cache_all() +check_cache_all() { # cache.direct is supposed to be inherited by both bs->file and # bs->backing @@ -231,7 +231,7 @@ drv_bk="if=none,file=json:{'driver':'$IMGFMT',,'file':'backing-file',,'node-name drv_file="if=none,driver=file,filename=$TEST_IMG,node-name=file" drv_img="if=none,id=blk,file=json:{'driver':'$IMGFMT',,'file':'file',,'backing':'backing',,'node-name':'image'}" -function check_cache_all_separate() +check_cache_all_separate() { # Check cache.direct |