aboutsummaryrefslogtreecommitdiff
path: root/tests/qapi-schema/unclosed-string.out
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2015-11-05 23:35:25 -0700
committerMarkus Armbruster <armbru@redhat.com>2015-11-09 16:45:05 +0100
commit748053c97b11039f657525fd7d57a39806d8083e (patch)
tree58a89ab8694242fed30fd5da0f64fd15c80bbe4b /tests/qapi-schema/unclosed-string.out
parent9d5c1dc117d1ad881bbc76f6990ee1f9e9f8ef7f (diff)
qapi: Use generated TestStruct machinery in tests
Commit d88f5fd and friends first introduced the various test-qmp-* tests in 2011, with duplicated hand-rolled TestStruct machinery, to make sure the qapi visitor interface was tested. Later, commit 4f193e3 in 2013 added a .json file for further testing use by the files, but without consolidating any of the existing hand-rolled visitors. And with four copies, subtle differences have crept in, between the tests themselves (mainly whitespace differences, but also a question of whether to use NULL or "TestStruct" when calling visit_start_struct()) and from what the generator produces (the hand-rolled versions did not cater to partially-allocated objects, because they did not have a deallocation usage). Of course, just because the visitor interface is tested does not mean it is a sane interface; and future patches will be changing some of the visitor contracts. Rather than having to duplicate the cleanup work in each copy of the TestStruct visitor, and keep each hand-rolled copy in sync with what the generator supplies, we might as well just test what the generator should give us in the first place. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1446791754-23823-2-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/qapi-schema/unclosed-string.out')
0 files changed, 0 insertions, 0 deletions