aboutsummaryrefslogtreecommitdiff
path: root/tests/qapi-schema/enum-bad-prefix.json
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2015-08-26 14:21:20 +0100
committerDaniel P. Berrange <berrange@redhat.com>2015-09-15 10:59:28 +0100
commit351d36e454cddc67a1675740916636a7ccbf1c4b (patch)
tree23b0d0dd79925c36ca3517070a106c4f2c910b6e /tests/qapi-schema/enum-bad-prefix.json
parent007e620a7576e4ce2ea6955541e87d8ae8ed32ae (diff)
qapi: allow override of default enum prefix naming
The camel_to_upper() method applies some heuristics to turn a mixed case type name into an all-uppercase name. This is used for example, to generate enum constant name prefixes. The heuristics don't also generate a satisfactory name though. eg { 'enum': 'QCryptoTLSCredsEndpoint', 'data': ['client', 'server']} Results in Q_CRYPTOTLS_CREDS_ENDPOINT_CLIENT. This has an undesirable _ after the initial Q and is missing an _ between the CRYPTO & TLS strings. Rather than try to add more and more heuristics to try to cope with this, simply allow the QAPI schema to specify the desired enum constant prefix explicitly. eg { 'enum': 'QCryptoTLSCredsEndpoint', 'prefix': 'QCRYPTO_TLS_CREDS_ENDPOINT', 'data': ['client', 'server']} Now gives the QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT name. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Diffstat (limited to 'tests/qapi-schema/enum-bad-prefix.json')
-rw-r--r--tests/qapi-schema/enum-bad-prefix.json2
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/qapi-schema/enum-bad-prefix.json b/tests/qapi-schema/enum-bad-prefix.json
new file mode 100644
index 0000000000..996f628f6d
--- /dev/null
+++ b/tests/qapi-schema/enum-bad-prefix.json
@@ -0,0 +1,2 @@
+# The prefix must be a string type
+{ 'enum': 'MyEnum', 'data': [ 'one' ], 'prefix': [ 'fish' ] }