diff options
| author | John Snow <jsnow@redhat.com> | 2021-04-21 14:20:22 -0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2021-04-30 12:59:54 +0200 |
| commit | 4918bb7defbdcb1e27cc2adf4e1604486d778ece (patch) | |
| tree | 0082b34f878d1c7dc8cf42c493a2597de312f253 /tests/qapi-schema/alternate-data-invalid.err | |
| parent | 926bb8add7c549496c612fcd4a32f3cf37883c2a (diff) | |
qapi/expr.py: Check type of union and alternate 'data' member
Prior to this commit, specifying a non-object value here causes the QAPI
parser to crash in expr.py with a stack trace with (likely) an
AttributeError when we attempt to call that value's items() method.
This member needs to be an object (Dict), and not anything else. Add a
check for this with a nicer error message, and formalize that check with
new test cases that exercise that error.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210421182032.3521476-8-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/qapi-schema/alternate-data-invalid.err')
| -rw-r--r-- | tests/qapi-schema/alternate-data-invalid.err | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/qapi-schema/alternate-data-invalid.err b/tests/qapi-schema/alternate-data-invalid.err new file mode 100644 index 0000000000..55f1033aef --- /dev/null +++ b/tests/qapi-schema/alternate-data-invalid.err @@ -0,0 +1,2 @@ +alternate-data-invalid.json: In alternate 'Alt': +alternate-data-invalid.json:2: 'data' must be an object |