aboutsummaryrefslogtreecommitdiff
path: root/tests/ahci-test.c
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2015-09-17 14:17:04 -0400
committerJohn Snow <jsnow@redhat.com>2015-09-17 14:17:04 -0400
commitaaeda4a3c9e4d1d25c65ce8ca98e2de06daf1eec (patch)
treefd10123de60b8c4e2bbf46bcdd9ca190af577a67 /tests/ahci-test.c
parent16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d (diff)
ide: unify io_buffer_offset increments
IDEState's io_buffer_offset was originally added to keep track of offsets in AHCI rather exclusively, but it was added to IDEState instead of an AHCI-specific structure. AHCI fakes all PIO transfers using DMA and a scatter-gather list. When the core or atapi layers invoke HBA-specific mechanisms for transfers, they do not always know that it is being backed by DMA or a sglist, so this offset is not always updated by the HBA code everywhere. If we modify it in dma_buf_commit, however, any HBA that needs to use this offset to manage operating on only part of a sglist will have access to it. This will fix ATAPI PIO transfers performed through the AHCI HBA, which were previously not modifying this value appropriately. This will fix ATAPI PIO transfers larger than one sector. Reported-by: Hannes Reinecke <hare@suse.de> Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Tested-by: Laszlo Ersek <lersek@redhat.com> Message-id: 1440546331-29087-2-git-send-email-jsnow@redhat.com CC: qemu-stable@nongnu.org
Diffstat (limited to 'tests/ahci-test.c')
0 files changed, 0 insertions, 0 deletions