diff options
| author | John Snow <jsnow@redhat.com> | 2015-02-05 12:41:20 -0500 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2015-02-16 15:07:17 +0000 |
| commit | 36e367261c15f0fa9acfbe9f4301c96e19be7f52 (patch) | |
| tree | 8d193bd1a7c701529a9f578991420ac5faf42e83 /tests/ahci-test.c | |
| parent | d1ef883894f0661f9994bc937ba09077a32a8bee (diff) | |
qtest/ahci: Demagic ahci tests.
Add human-readable command names and other miscellaneous #defines
to help make the code more readable.
Some of these definitions are not yet used in this current series,
but for convenience and sanity they have been lumped together here,
as it's more trouble than it is worth in a test suite to hand-pick,
one-by-one, which preprocessor definitions are useful per-each test.
These definitions include:
ATA Command Mnemonics
Current expected AHCI sector size
FIS magic bytes
REG_H2D_FIS flags
Command Header flags
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1423158090-25580-10-git-send-email-jsnow@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'tests/ahci-test.c')
| -rw-r--r-- | tests/ahci-test.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/ahci-test.c b/tests/ahci-test.c index b67d935597..211274e8c3 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -705,9 +705,9 @@ static void ahci_test_identify(AHCIQState *ahci) /* Construct our Command Header (set_command_header handles endianness.) */ memset(&cmd, 0x00, sizeof(cmd)); - cmd.flags = 5; /* reg_h2d_fis is 5 double-words long */ - cmd.flags |= 0x400; /* clear PxTFD.STS.BSY when done */ - cmd.prdtl = 1; /* One PRD table entry. */ + cmd.flags = 5; /* reg_h2d_fis is 5 double-words long */ + cmd.flags |= CMDH_CLR_BSY; /* clear PxTFD.STS.BSY when done */ + cmd.prdtl = 1; /* One PRD table entry. */ cmd.prdbc = 0; cmd.ctba = table; @@ -719,10 +719,10 @@ static void ahci_test_identify(AHCIQState *ahci) /* Construct our Command FIS, Based on http://wiki.osdev.org/AHCI */ memset(&fis, 0x00, sizeof(fis)); - fis.fis_type = 0x27; /* Register Host-to-Device FIS */ - fis.command = 0xEC; /* IDENTIFY */ + fis.fis_type = REG_H2D_FIS; /* Register Host-to-Device FIS */ + fis.command = CMD_IDENTIFY; fis.device = 0; - fis.flags = 0x80; /* Indicate this is a command FIS */ + fis.flags = REG_H2D_FIS_CMD; /* Indicate this is a command FIS */ /* We've committed nothing yet, no interrupts should be posted yet. */ g_assert_cmphex(ahci_px_rreg(ahci, i, AHCI_PX_IS), ==, 0); |