aboutsummaryrefslogtreecommitdiff
path: root/tcg
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2024-02-12 20:38:18 +0000
committerRichard Henderson <richard.henderson@linaro.org>2024-02-13 07:42:45 -1000
commite41f1825b43796c3508ef309ed0b150ef89acc44 (patch)
tree06f9e099003a11e02172b059a22510a801823d18 /tcg
parentc0e688153f299d5d493989c80bcc84c9cf36d6a6 (diff)
tcg/arm: Fix goto_tb for large translation blocks
Correct arithmetic for separating high and low on a large negative number. Cc: qemu-stable@nongnu.org Fixes: 79ffece4447 ("tcg/arm: Implement direct branch for goto_tb") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1714 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'tcg')
-rw-r--r--tcg/arm/tcg-target.c.inc4
1 files changed, 2 insertions, 2 deletions
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index ffd23ef789..6a04c73c76 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1771,9 +1771,9 @@ static void tcg_out_goto_tb(TCGContext *s, int which)
* shifted immediate from pc.
*/
int h = -i_disp;
- int l = h & 0xfff;
+ int l = -(h & 0xfff);
- h = encode_imm_nofail(h - l);
+ h = encode_imm_nofail(h + l);
tcg_out_dat_imm(s, COND_AL, ARITH_SUB, TCG_REG_R0, TCG_REG_PC, h);
tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_R0, l);
}