diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2023-07-28 10:22:52 -0700 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2023-08-04 19:14:46 +0300 |
| commit | f8e673df7e10be0759778963adf5238e736d5ee4 (patch) | |
| tree | f5d6239ab9fad1d4aebdca89f1d6a4c337ef04a9 /target | |
| parent | 357b42486c4ad23757c588f92cf2d7d17e2d1fb8 (diff) | |
target/ppc: Disable goto_tb with architectural singlestep
The change to use translator_use_goto_tb went too far, as the
CF_SINGLE_STEP flag managed by the translator only handles
gdb single stepping and not the architectural single stepping
modeled in DisasContext.singlestep_enabled.
Fixes: 6e9cc373ec5 ("target/ppc: Use translator_use_goto_tb")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
(cherry picked from commit 2e718e665706d5fcc3e3501bda26f277f055ed85)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'target')
| -rw-r--r-- | target/ppc/translate.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 49a6b91842..26222e9078 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -4132,6 +4132,9 @@ static void pmu_count_insns(DisasContext *ctx) static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { + if (unlikely(ctx->singlestep_enabled)) { + return false; + } return translator_use_goto_tb(&ctx->base, dest); } |