aboutsummaryrefslogtreecommitdiff
path: root/target
diff options
context:
space:
mode:
authorFam Zheng <famz@redhat.com>2017-03-17 14:14:47 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2017-03-24 11:49:03 +0100
commit71407786054cad26de7ef66718b2a57a4bcb49b5 (patch)
tree66260ec790a8909778a614fa64c93ac19217b6b5 /target
parent3d69f821616a578aeed569b3b56e157922819602 (diff)
virtio-scsi: Fix acquire/release in dataplane handlers
After the AioContext lock push down, there is a race between virtio_scsi_dataplane_start and those "assert(s->ctx && s->dataplane_started)", because the latter doesn't isn't wrapped in aio_context_acquire. Reproducer is simply booting a Fedora guest with an empty virtio-scsi-dataplane controller: qemu-system-x86_64 \ -drive if=none,id=root,format=raw,file=Fedora-Cloud-Base-25-1.3.x86_64.raw \ -device virtio-scsi \ -device scsi-disk,drive=root,bootindex=1 \ -object iothread,id=io \ -device virtio-scsi-pci,iothread=io \ -net user,hostfwd=tcp::10022-:22 -net nic,model=virtio -m 2048 \ --enable-kvm Fix this by moving acquire/release pairs from virtio_scsi_handle_*_vq to their callers - and wrap the broken assertions in. Signed-off-by: Fam Zheng <famz@redhat.com> Message-Id: <20170317061447.16243-3-famz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'target')
0 files changed, 0 insertions, 0 deletions