diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-04-17 21:17:58 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-04-18 22:18:59 +0200 |
| commit | fad866daa85c65267fa44de40f10cc1ee904ae1a (patch) | |
| tree | b94800a130298a2a9f6d9f41ad5692bf5fa6964e /target/ppc/monitor.c | |
| parent | 0442428a8976b4f94e04d24b5db9eb1b678d82c4 (diff) | |
target: Clean up how the dump_mmu() print
The various dump_mmu() take an fprintf()-like callback and a FILE * to
pass to it, and so do their helper functions. Passing around callback
and argument is rather tiresome.
Most dump_mmu() are called only by the target's hmp_info_tlb(). These
all pass monitor_printf() cast to fprintf_function and the current
monitor cast to FILE *.
SPARC's dump_mmu() gets also called from target/sparc/ldst_helper.c a
few times #ifdef DEBUG_MMU. These calls pass fprintf() and stdout.
The type-punning is technically undefined behaviour, but works in
practice. Clean up: drop the callback, and call qemu_printf()
instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190417191805.28198-11-armbru@redhat.com>
Diffstat (limited to 'target/ppc/monitor.c')
| -rw-r--r-- | target/ppc/monitor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/ppc/monitor.c b/target/ppc/monitor.c index 04deec8030..42e58163fc 100644 --- a/target/ppc/monitor.c +++ b/target/ppc/monitor.c @@ -66,7 +66,7 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict) monitor_printf(mon, "No CPU available\n"); return; } - dump_mmu((FILE*)mon, (fprintf_function)monitor_printf, env1); + dump_mmu(env1); } const MonitorDef monitor_defs[] = { |