aboutsummaryrefslogtreecommitdiff
path: root/target/loongarch/insn_trans/trans_fmemory.c.inc
diff options
context:
space:
mode:
authorJiajie Chen <c@jia.je>2023-08-20 18:56:59 +0800
committerSong Gao <gaosong@loongson.cn>2023-08-24 16:58:16 +0800
commit3f6bec4a9f7c159d32d49f6df5c2c3d587b953b9 (patch)
treec023c294a5aca33581e3fc67ba05094b0c6e33c5 /target/loongarch/insn_trans/trans_fmemory.c.inc
parent17ffe331a923c9015887917b27212ab39ff1d8ea (diff)
hw/loongarch: Fix ACPI processor id off-by-one error
In hw/acpi/aml-build.c:build_pptt() function, the code assumes that the ACPI processor id equals to the cpu index, for example if we have 8 cpus, then the ACPI processor id should be in range 0-7. However, in hw/loongarch/acpi-build.c:build_madt() function we broke the assumption. If we have 8 cpus again, the ACPI processor id in MADT table would be in range 1-8. It violates the following description taken from ACPI spec 6.4 table 5.138: If the processor structure represents an actual processor, this field must match the value of ACPI processor ID field in the processor’s entry in the MADT. It will break the latest Linux 6.5-rc6 with the following error message: ACPI PPTT: PPTT table found, but unable to locate core 7 (8) Invalid BIOS PPTT Here 7 is the last cpu index, 8 is the ACPI processor id learned from MADT. With this patch, Linux can properly detect SMT threads when "-smp 8,sockets=1,cores=4,threads=2" is passed: Thread(s) per core: 2 Core(s) per socket: 2 Socket(s): 2 The detection of number of sockets is still wrong, but that is out of scope of the commit. Signed-off-by: Jiajie Chen <c@jia.je> Reviewed-by: Bibo Mao <maobibo@loongson.cn> Message-Id: <20230820105658.99123-2-c@jia.je> Signed-off-by: Song Gao <gaosong@loongson.cn>
Diffstat (limited to 'target/loongarch/insn_trans/trans_fmemory.c.inc')
0 files changed, 0 insertions, 0 deletions