diff options
| author | Eric Blake <eblake@redhat.com> | 2020-04-20 12:53:07 -0500 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2020-07-13 09:01:01 -0500 |
| commit | 8cf58a49f883f089e7d4b6e19acc987085d024fd (patch) | |
| tree | fffad750f4fe2a9933b2365ccbaa9fef30daa6df /target/i386 | |
| parent | 00d69986da83a74f6f5731c80f8dd09fde95d19a (diff) | |
hax: Fix setting of FD_CLOEXEC
Blindly setting FD_CLOEXEC without a read-modify-write will
inadvertently clear any other intentionally-set bits, such as a
proposed new bit for designating a fd that must behave in 32-bit mode.
Use our wrapper function instead of an incorrect hand-rolled version.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200420175309.75894-2-eblake@redhat.com>
Reviewed-by: Colin Xu <colin.xu@intel.com>
Diffstat (limited to 'target/i386')
| -rw-r--r-- | target/i386/hax-posix.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/target/i386/hax-posix.c b/target/i386/hax-posix.c index 3bad89f133..5f9d1b803d 100644 --- a/target/i386/hax-posix.c +++ b/target/i386/hax-posix.c @@ -23,7 +23,7 @@ hax_fd hax_mod_open(void) fprintf(stderr, "Failed to open the hax module\n"); } - fcntl(fd, F_SETFD, FD_CLOEXEC); + qemu_set_cloexec(fd); return fd; } @@ -147,7 +147,7 @@ hax_fd hax_host_open_vm(struct hax_state *hax, int vm_id) fd = open(vm_name, O_RDWR); g_free(vm_name); - fcntl(fd, F_SETFD, FD_CLOEXEC); + qemu_set_cloexec(fd); return fd; } @@ -200,7 +200,7 @@ hax_fd hax_host_open_vcpu(int vmid, int vcpuid) if (fd < 0) { fprintf(stderr, "Failed to open the vcpu devfs\n"); } - fcntl(fd, F_SETFD, FD_CLOEXEC); + qemu_set_cloexec(fd); return fd; } |