diff options
author | Peter Maydell <peter.maydell@linaro.org> | 2023-09-12 15:04:23 +0100 |
---|---|---|
committer | Michael Tokarev <mjt@tls.msk.ru> | 2023-10-03 02:00:54 +0300 |
commit | 7329cc1c196a1a7048c027ae0eaee6eaa7b12bf9 (patch) | |
tree | 3e6663014d14d2e1386b3caf14cc32e9c1ec614a /target/arm/tcg/translate-a64.h | |
parent | d0cd94e2b6eff0dbe3746da6b2c4c4643eecb101 (diff) |
target/arm: Don't skip MTE checks for LDRT/STRT at EL0
The LDRT/STRT "unprivileged load/store" instructions behave like
normal ones if executed at EL0. We handle this correctly for
the load/store semantics, but get the MTE checking wrong.
We always look at s->mte_active[is_unpriv] to see whether we should
be doing MTE checks, but in hflags.c when we set the TB flags that
will be used to fill the mte_active[] array we only set the
MTE0_ACTIVE bit if UNPRIV is true (i.e. we are not at EL0).
This means that a LDRT at EL0 will see s->mte_active[1] as 0,
and will not do MTE checks even when MTE is enabled.
To avoid the translate-time code having to do an explicit check on
s->unpriv to see if it is OK to index into the mte_active[] array,
duplicate MTE_ACTIVE into MTE0_ACTIVE when UNPRIV is false.
(This isn't a very serious bug because generally nobody executes
LDRT/STRT at EL0, because they have no use there.)
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230912140434.1333369-2-peter.maydell@linaro.org
(cherry picked from commit 903dbefc2b6918c10d12d9aafa0168cee8d287c7)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'target/arm/tcg/translate-a64.h')
0 files changed, 0 insertions, 0 deletions