diff options
| author | Eduardo Habkost <ehabkost@redhat.com> | 2015-03-03 22:54:03 -0300 |
|---|---|---|
| committer | Eduardo Habkost <ehabkost@redhat.com> | 2015-03-09 16:30:02 -0300 |
| commit | 0f4b210e504d7db42b96882e94481f444e420fe3 (patch) | |
| tree | 8b65f90baf7226183a29b7272f351836fa9ae0b9 /target-i386 | |
| parent | 5eb2f7a4df03b53f7eaf56d2dd53d75328909826 (diff) | |
target-i386: Remove unused APIC ID default code
The existing apic_id = cpu_index code has no visible effect: the PC code
already initializes the APIC ID according to the topology on
pc_new_cpu(), and linux-user memcpy()s the CPU state (including
cpuid_apic_id) on cpu_copy().
Remove the dead code and simply let APIC ID to to be 0 by default. This
doesn't change behavior of PC because apic-id is already explicitly set,
and doesn't affect linux-user because APIC ID was already always 0.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'target-i386')
| -rw-r--r-- | target-i386/cpu.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2f3a4504ea..3e1a0e7822 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2901,7 +2901,6 @@ static void x86_cpu_initfn(Object *obj) NULL, NULL, (void *)cpu->filtered_features, NULL); cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY; - env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index); x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); |