diff options
| author | Jan Kiszka <jan.kiszka@siemens.com> | 2009-05-02 02:18:38 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-05-22 10:50:34 -0500 |
| commit | f8d926e9cd96e52ebcfd9ffdeab83c0d5e6b9622 (patch) | |
| tree | 510d530bbec3c739cc23fcc248fe188738fd0b28 /target-i386 | |
| parent | d33a1810d7f558dd1d486bc84f1cf8f96c982e2d (diff) | |
kvm: x86: Save/restore KVM-specific CPU states
Save and restore all so far neglected KVM-specific CPU states. Handling
the TSC stabilizes migration in KVM mode. The interrupt_bitmap and
mp_state are currently unused, but will become relevant for in-kernel
irqchip support. By including proper saving/restoring already, we avoid
having to increment CPU_SAVE_VERSION later on once again.
v2:
- initialize mp_state runnable (for the boot CPU)
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'target-i386')
| -rw-r--r-- | target-i386/cpu.h | 3 | ||||
| -rw-r--r-- | target-i386/kvm.c | 10 | ||||
| -rw-r--r-- | target-i386/machine.c | 16 |
3 files changed, 26 insertions, 3 deletions
diff --git a/target-i386/cpu.h b/target-i386/cpu.h index c6bca942f4..eaa623ca58 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -669,6 +669,7 @@ typedef struct CPUX86State { /* For KVM */ uint64_t interrupt_bitmap[256 / 64]; + uint32_t mp_state; /* in order to simplify APIC support, we leave this pointer to the user */ @@ -837,7 +838,7 @@ static inline int cpu_get_time_fast(void) #define cpu_signal_handler cpu_x86_signal_handler #define cpu_list x86_cpu_list -#define CPU_SAVE_VERSION 8 +#define CPU_SAVE_VERSION 9 /* MMU modes definitions */ #define MMU_MODE0_SUFFIX _kernel diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7cdcf31cab..c4fd4848c5 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -126,6 +126,8 @@ int kvm_arch_init_vcpu(CPUState *env) uint32_t limit, i, j, cpuid_i; uint32_t unused; + env->mp_state = KVM_MP_STATE_RUNNABLE; + cpuid_i = 0; cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused); @@ -648,6 +650,14 @@ int kvm_arch_put_registers(CPUState *env) if (ret < 0) return ret; + ret = kvm_put_mp_state(env); + if (ret < 0) + return ret; + + ret = kvm_get_mp_state(env); + if (ret < 0) + return ret; + return 0; } diff --git a/target-i386/machine.c b/target-i386/machine.c index 69a03a4df1..bb8b9dbd5a 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -140,6 +140,12 @@ void cpu_save(QEMUFile *f, void *opaque) qemu_put_be64s(f, &env->mtrr_var[i].base); qemu_put_be64s(f, &env->mtrr_var[i].mask); } + + for (i = 0; i < sizeof(env->interrupt_bitmap)/8; i++) { + qemu_put_be64s(f, &env->interrupt_bitmap[i]); + } + qemu_put_be64s(f, &env->tsc); + qemu_put_be32s(f, &env->mp_state); } #ifdef USE_X86LDOUBLE @@ -174,8 +180,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id) uint16_t fpus, fpuc, fptag, fpregs_format; int32_t a20_mask; - if (version_id != 3 && version_id != 4 && version_id != 5 - && version_id != 6 && version_id != 7 && version_id != 8) + if (version_id < 3 || version_id > CPU_SAVE_VERSION) return -EINVAL; for(i = 0; i < CPU_NB_REGS; i++) qemu_get_betls(f, &env->regs[i]); @@ -319,6 +324,13 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id) qemu_get_be64s(f, &env->mtrr_var[i].mask); } } + if (version_id >= 9) { + for (i = 0; i < sizeof(env->interrupt_bitmap)/8; i++) { + qemu_get_be64s(f, &env->interrupt_bitmap[i]); + } + qemu_get_be64s(f, &env->tsc); + qemu_get_be32s(f, &env->mp_state); + } /* XXX: ensure compatiblity for halted bit ? */ /* XXX: compute redundant hflags bits */ |