aboutsummaryrefslogtreecommitdiff
path: root/subprojects
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2022-12-19 12:58:30 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2023-01-11 10:44:34 +0100
commit8b8437259ca68e8e2145e0566cf67a29d6ee1816 (patch)
tree8db5a7f22c6aa14384a630b74c1ef80e973b6c90 /subprojects
parent88a0ef00d70c61fdb46ee88ced87046dfb11eb3f (diff)
hw/display: avoid creating empty loadable modules
When using --disable-virglrenderer, QEMU still creates hw-display-virtio-gpu-gl.so hw-display-virtio-vga-gl.so hw-display-virtio-gpu-pci-gl.so but when these are loaded, they provide no functionality as the code which registers types is not compiled in. Funtionally this is relatively harmless, because QEMU is fine loading a module with no types. This is rather confusing for users and OS distro maintainers though, as they think they have the GL functionality built, but in fact the module they are looking at provides nothing of value. The root cause is the use of 'when/if_true' rules when adding sources to the module source set. If all the rules evaluate to false, then we have declared the module, but not added anything to it. We need to put declaration of the entire module inside a condition based on existance of the 3rd party library deps that are mandatory. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1352 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20221219125830.2369169-1-berrange@redhat.com> [Do not check for pixman. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'subprojects')
0 files changed, 0 insertions, 0 deletions