aboutsummaryrefslogtreecommitdiff
path: root/slirp/arp_table.c
diff options
context:
space:
mode:
authorSamuel Thibault <samuel.thibault@gnu.org>2014-05-14 03:13:09 +0200
committerEdgar E. Iglesias <edgar.iglesias@xilinx.com>2014-06-09 01:49:28 +0200
commit959e41473f2179850578482052fb73b913bc4e42 (patch)
tree03242d926a2e182aeabe4ba81735d2a97f70a196 /slirp/arp_table.c
parent37654d9e6af84003982f8b9a5d59a4aef28e0a79 (diff)
slirp/arp: do not special-case bogus IP addresses
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Silently avoid having 0.0.0.0 as a destination, however. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> [Edgar: Minor change to subject] Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Diffstat (limited to 'slirp/arp_table.c')
-rw-r--r--slirp/arp_table.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/slirp/arp_table.c b/slirp/arp_table.c
index ecdb0baee4..bcaeb44860 100644
--- a/slirp/arp_table.c
+++ b/slirp/arp_table.c
@@ -37,12 +37,7 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN])
ethaddr[0], ethaddr[1], ethaddr[2],
ethaddr[3], ethaddr[4], ethaddr[5]));
- /* Check 0.0.0.0/8 invalid source-only addresses */
- if ((ip_addr & htonl(~(0xfU << 28))) == 0) {
- return;
- }
-
- if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) {
+ if (ip_addr == 0 || ip_addr == 0xffffffff || ip_addr == broadcast_addr) {
/* Do not register broadcast addresses */
return;
}
@@ -73,9 +68,6 @@ bool arp_table_search(Slirp *slirp, uint32_t ip_addr,
DEBUG_CALL("arp_table_search");
DEBUG_ARG("ip = 0x%x", ip_addr);
- /* Check 0.0.0.0/8 invalid source-only addresses */
- assert((ip_addr & htonl(~(0xfU << 28))) != 0);
-
/* If broadcast address */
if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) {
/* return Ethernet broadcast address */