diff options
author | Kevin Wolf <kwolf@redhat.com> | 2019-07-22 17:44:27 +0200 |
---|---|---|
committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2019-11-12 16:31:49 -0600 |
commit | e092a17d3825a8f2c93cb429aaa5d857b579b64c (patch) | |
tree | f5c1f9fb1191af3ac67e4edd55a45a155a16b203 /simpletrace.h | |
parent | 088f1e8fd9e790bc5766bd43af134230abcff6dd (diff) |
mirror: Keep mirror_top_bs drained after dropping permissions
mirror_top_bs is currently implicitly drained through its connection to
the source or the target node. However, the drain section for target_bs
ends early after moving mirror_top_bs from src to target_bs, so that
requests can already be restarted while mirror_top_bs is still present
in the chain, but has dropped all permissions and therefore runs into an
assertion failure like this:
qemu-system-x86_64: block/io.c:1634: bdrv_co_write_req_prepare:
Assertion `child->perm & BLK_PERM_WRITE' failed.
Keep mirror_top_bs drained until all graph changes have completed.
Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
(cherry picked from commit d2da5e288a2e71e82866c8fdefd41b5727300124)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'simpletrace.h')
0 files changed, 0 insertions, 0 deletions