aboutsummaryrefslogtreecommitdiff
path: root/simpletrace.h
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>2011-03-13 20:14:30 +0000
committerBlue Swirl <blauwirbel@gmail.com>2011-03-15 18:03:26 +0000
commit31d3c9b8c15d7b42f508d5fc2adc4abb7c732b70 (patch)
tree06e4b51f2b49992dac1196d1eb3e6cb62df0f026 /simpletrace.h
parentcc015e9a5dde2f03f123357fa060acbdfcd570a4 (diff)
simpletrace: Move st_init() error reporting
User emulator builds do not have error_report() so it should not be used by simpletrace.c. In fact, error reporting inside simpletrace.c is inappropriate and should be done by the caller instead. This patch moves st_init() error reporting out to its caller, vl.c:main(). Reported-by: Blue Swirl <blauwirbel@gmail.com> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'simpletrace.h')
-rw-r--r--simpletrace.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/simpletrace.h b/simpletrace.h
index 3a5bd9fb9d..8d893bd849 100644
--- a/simpletrace.h
+++ b/simpletrace.h
@@ -37,11 +37,11 @@ void st_print_trace_file_status(FILE *stream, fprintf_function stream_printf);
void st_set_trace_file_enabled(bool enable);
bool st_set_trace_file(const char *file);
void st_flush_trace_buffer(void);
-void st_init(const char *file);
+bool st_init(const char *file);
#else
-static inline void st_init(const char *file)
+static inline bool st_init(const char *file)
{
- /* Do nothing */
+ return true;
}
#endif /* !CONFIG_SIMPLE_TRACE */