diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2018-11-29 09:31:41 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2019-01-11 13:57:23 +0100 |
| commit | fd9c0cfeb73bd72ca2bd3b6e8db7528bc22a43da (patch) | |
| tree | dc164b83c81babd0e68b4a8d722ea93202462894 /scripts | |
| parent | 1ff7ebf33b67b4ec7ea663827e74fe54ac469618 (diff) | |
checkpatch: check Signed-off-by in --mailback mode
Pull the test before the anticipated exits from the process sub.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66eb68e85a..42e782a656 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2864,6 +2864,10 @@ sub process { } } + if ($is_patch && $chk_signoff && $signoff == 0) { + ERROR("Missing Signed-off-by: line(s)\n"); + } + # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) { @@ -2885,9 +2889,6 @@ sub process { if (!$is_patch) { ERROR("Does not appear to be a unified-diff format patch\n"); } - if ($is_patch && $chk_signoff && $signoff == 0) { - ERROR("Missing Signed-off-by: line(s)\n"); - } print report_dump(); if ($summary && !($clean == 1 && $quiet == 1)) { |