diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2015-05-04 14:18:09 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2015-05-05 10:42:11 +0200 |
| commit | 2e1c92daff752c056ae10087e6b1702b0460af88 (patch) | |
| tree | b6a85e5a4d7f410cbcdea5917cd7921f7e9ef288 /scripts | |
| parent | 5bccbb04a4abba7af4398de992bf06d585fd1333 (diff) | |
coverity: fix address_space_rw model
If the is_write argument is true, address_space_rw writes to memory
and thus reads from the buffer. The opposite holds if is_write is
false. Fix the model.
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/coverity-model.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c index 224d2d1873..617f67d716 100644 --- a/scripts/coverity-model.c +++ b/scripts/coverity-model.c @@ -49,7 +49,7 @@ typedef uint64_t hwaddr; typedef uint32_t MemTxResult; typedef uint64_t MemTxAttrs; -static void __write(uint8_t *buf, ssize_t len) +static void __bufwrite(uint8_t *buf, ssize_t len) { int first, last; __coverity_negative_sink__(len); @@ -59,7 +59,7 @@ static void __write(uint8_t *buf, ssize_t len) __coverity_writeall__(buf); } -static void __read(uint8_t *buf, ssize_t len) +static void __bufread(uint8_t *buf, ssize_t len) { __coverity_negative_sink__(len); if (len == 0) return; @@ -74,7 +74,7 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs attrs, // TODO: investigate impact of treating reads as producing // tainted data, with __coverity_tainted_data_argument__(buf). - if (is_write) __write(buf, len); else __read(buf, len); + if (is_write) __bufread(buf, len); else __bufwrite(buf, len); return result; } |