diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2015-09-07 11:53:02 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-08-10 12:22:33 +0200 |
| commit | 8fbe3d1fcfa16c543f49f24e7cdfbf0024459341 (patch) | |
| tree | 73348f3bfa71549a15327f38cf591e35e3f37956 /scripts | |
| parent | 93eb8e31f38b3eb612e522c62e8932d7fd576ff9 (diff) | |
CODING_STYLE, checkpatch: update line length rules
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
exception to the rule, so do the latter.
Some on the list expressed their preference for a soft limit that
is slightly lower than 80 characters, to account for extra characters
in unified diffs (including three-way diffs) and for email quoting.
However, there was no consensus on this so keep the 80-character
soft limit and add a hard limit at 90.
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fea576d1b4..ba6760d4b3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1336,12 +1336,16 @@ sub process { # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/); -#80 column limit +#90 column limit if ($line =~ /^\+/ && !($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && $length > 80) { - WARN("line over 80 characters\n" . $herecurr); + if ($length > 90) { + ERROR("line over 90 characters\n" . $herecurr); + } else { + WARN("line over 80 characters\n" . $herecurr); + } } # check for spaces before a quoted newline |