diff options
| author | Amador Pahim <apahim@redhat.com> | 2018-01-22 21:50:31 +0100 |
|---|---|---|
| committer | Eduardo Habkost <ehabkost@redhat.com> | 2018-02-05 19:53:55 -0200 |
| commit | 17589cae908222d572953d4c85f72aa833e87d58 (patch) | |
| tree | c6a2b84c23c4d8bfc1d58eb3ade1e66a4593e066 /scripts/qemu.py | |
| parent | 04a963b4953be6c7f1899cfe0a0a11d03292c18b (diff) | |
qemu.py: use poll() instead of 'returncode'
The 'returncode' Popen attribute is not guaranteed to be updated. It
actually depends on a call to either poll(), wait() or communicate().
On the other hand, poll() will: "Check if child process has terminated.
Set and return returncode attribute."
Let's use the poll() to check whether the process is running and to get
the updated process exit code, when the process is finished.
Reviewed-by: Fam Zheng <famz@redhat.com>
eviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Amador Pahim <apahim@redhat.com>
Message-Id: <20180122205033.24893-5-apahim@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'scripts/qemu.py')
| -rw-r--r-- | scripts/qemu.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/qemu.py b/scripts/qemu.py index 52cf09eebd..dcb4f0ffe6 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -150,12 +150,12 @@ class QEMUMachine(object): raise def is_running(self): - return self._popen is not None and self._popen.returncode is None + return self._popen is not None and self._popen.poll() is None def exitcode(self): if self._popen is None: return None - return self._popen.returncode + return self._popen.poll() def get_pid(self): if not self.is_running(): |