diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-04-22 15:07:08 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-04-29 08:01:52 +0200 |
| commit | abc9bf69a66a11499a801ff545b8fe7adbb3a04c (patch) | |
| tree | 736e0b8fb8494c84a24ce2740bcaa086cb3ddd5b /qom | |
| parent | 77ed971b9d96a288e497509054e1e59493ffd1fc (diff) | |
cpus: Fix configure_icount() error API violation
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
configure_icount() is wrong that way. Harmless, because its @errp is
always &error_abort or &error_fatal.
Just as wrong (and just as harmless): when it fails, it can still
update global state.
Fix all that.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200422130719.28225-4-armbru@redhat.com>
Diffstat (limited to 'qom')
0 files changed, 0 insertions, 0 deletions