diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-10-15 16:15:35 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2015-10-29 14:34:45 +0100 |
| commit | fcf73f66a67f5e58c18216f8c8651e38cf4d90af (patch) | |
| tree | ea430e78cc556fb332a9f3ec1c520e4d602700f3 /qobject/qfloat.c | |
| parent | 89cad9f3ec6b30d7550fb5704475fc9c3393a066 (diff) | |
qfloat qint: Make conversion from QObject * accept null
qobject_to_qfloat() and qobject_to_qint() crash on null, which is a
trap for the unwary. Return null instead, and simplify a few callers.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1444918537-18107-5-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'qobject/qfloat.c')
| -rw-r--r-- | qobject/qfloat.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qobject/qfloat.c b/qobject/qfloat.c index 7de0992dba..c86516327f 100644 --- a/qobject/qfloat.c +++ b/qobject/qfloat.c @@ -51,9 +51,9 @@ double qfloat_get_double(const QFloat *qf) */ QFloat *qobject_to_qfloat(const QObject *obj) { - if (qobject_type(obj) != QTYPE_QFLOAT) + if (!obj || qobject_type(obj) != QTYPE_QFLOAT) { return NULL; - + } return container_of(obj, QFloat, base); } |