diff options
| author | Luiz Capitulino <lcapitulino@redhat.com> | 2012-09-13 16:52:20 -0300 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2012-09-26 12:42:19 -0300 |
| commit | b224e5e2162a767dd56dbc366f796fbe45ca5baa (patch) | |
| tree | f57612bc208639b5e42443a0c3db3995866775c8 /qmp-commands.hx | |
| parent | a9940fc4cba811adfb296fe07b247ee707265f90 (diff) | |
qapi: convert add_client
Also fixes a few issues while there:
1. The fd returned by monitor_get_fd() leaks in most error conditions
2. monitor_get_fd() return value is not checked. Best case we get
an error that is not correctly reported, worse case one of the
functions using the fd (with value of -1) will explode
3. A few error conditions aren't reported
4. We now "use up" @fdname always. Before, it was left alone for
invalid @protocol
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qmp-commands.hx')
| -rw-r--r-- | qmp-commands.hx | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/qmp-commands.hx b/qmp-commands.hx index 6e21ddba61..36e08d9ffc 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1231,10 +1231,7 @@ EQMP { .name = "add_client", .args_type = "protocol:s,fdname:s,skipauth:b?,tls:b?", - .params = "protocol fdname skipauth tls", - .help = "add a graphics client", - .user_print = monitor_user_noop, - .mhandler.cmd_new = add_graphics_client, + .mhandler.cmd_new = qmp_marshal_input_add_client, }, SQMP |