diff options
author | Markus Armbruster <armbru@redhat.com> | 2015-03-23 19:22:10 +0100 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2015-04-02 15:30:39 +0200 |
commit | 19109131ca2701de1b4e083bd51172f376f7a5ef (patch) | |
tree | 15de7615efdaab26c53964f4c63a7d348a203589 /qemu-timer.c | |
parent | 19f33f16890fc5ec0d43841625ca44ef28767d1a (diff) |
sdhci: Make device "sdhci-pci" unavailable with -device
Device models aren't supposed to go on fishing expeditions for
backends. They should expose suitable properties for the user to set.
For onboard devices, board code sets them.
"sdhci-pci" picks up its block backend in its realize() method with
drive_get_next() instead. Already marked FIXME. See the commit that
added the FIXME for a more detailed explanation of what's wrong.
We can't fix this in time for the release, but since the device is new
in 2.3, we can set cannot_instantiate_with_device_add_yet to disable
it before this mistake becomes ABI, and we have to support command
lines like
$ qemu -drive if=sd -drive if=sd,file=sd.img -device sdhci-pci -device sdhci-pci
forever.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qemu-timer.c')
0 files changed, 0 insertions, 0 deletions