diff options
author | Peter Maydell <peter.maydell@linaro.org> | 2019-01-04 14:50:18 +0000 |
---|---|---|
committer | Thomas Huth <thuth@redhat.com> | 2019-01-22 06:26:32 +0100 |
commit | 739fc38778a8ead742b201fc801a3cacb9083f66 (patch) | |
tree | a7ce88183f613f971ae567962313e991ff4f660d /qemu-options-wrapper.h | |
parent | 7be41675f7cb16be7c8d2554add7a63fa43781a8 (diff) |
tests/hexloader-test: Don't pass -nographic to the QEMU under test
The hexloader test invokes QEMU with the -nographic argument. This
is unnecessary, because the qtest_initf() function will pass it
-display none, which suffices to disable the graphical window.
It also means that the QEMU process will make the stdin/stdout
O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per
"file description", this non-blocking behaviour is then shared
with any other process that's using the stdin/stdout of the
'make check' run, including make itself. This can result in make
falling over with "make: write error: stdout" because it got
an unexpected EINTR trying to write output messages to the terminal.
This is particularly noticable if running 'make check' in a loop with
while make check; do true; done
(It does not affect single make check runs so much because the
shell will remove the O_NONBLOCK status before it reads the
terminal for interactive input.)
Remove the unwanted -nographic argument.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'qemu-options-wrapper.h')
0 files changed, 0 insertions, 0 deletions