aboutsummaryrefslogtreecommitdiff
path: root/qemu-option-trace.texi
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2017-04-26 15:46:47 +0200
committerKevin Wolf <kwolf@redhat.com>2017-04-27 17:26:06 +0200
commit3258b91141090b05edcaab8f1d1dd355ca91b49a (patch)
treee820410d71b502312199cf6715869b5426ba67f7 /qemu-option-trace.texi
parentf13ce1be35b13f09c0a28269c74468f6766f0365 (diff)
qemu-img/convert: Use @opts for one thing only
After storing the creation options for the new image into @opts, we fetch some things for our own information, like the backing file name, or whether to use encryption or preallocation. With the -n parameter, there will not be any creation options; this is not too bad because this just means that querying a NULL @opts will always return the default value. However, we also use @opts for the --object options. Therefore, @opts is not necessarily NULL if -n was specified; instead, it may contain those options. In practice, this probably does not cause any problems because there most likely is no object that supports any of the parameters we query here, but this is neither something we should rely on nor does this variable reuse make the code very nice to read. Therefore, just use a separate variable for the --object options. Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qemu-option-trace.texi')
0 files changed, 0 insertions, 0 deletions