aboutsummaryrefslogtreecommitdiff
path: root/qemu-ga.texi
diff options
context:
space:
mode:
authorFam Zheng <famz@redhat.com>2018-09-14 15:26:15 +0800
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2018-10-21 21:22:17 +0200
commit6e157a0339793bb081705f52318fc77afd10addf (patch)
treeb28916158baccc6919994ab7cda862a04854e6f3 /qemu-ga.texi
parentb312532fd03413d0e6ae6767ec793a3e30f487b8 (diff)
slirp: Add sanity check for str option length
When user provides a long domainname or hostname that doesn't fit in the DHCP packet, we mustn't overflow the response packet buffer. Instead, report errors, following the g_warning() in the slirp->vdnssearch branch. Also check the strlen against 256 when initializing slirp, which limit is also from the protocol where one byte represents the string length. This gives an early error before the warning which is harder to notice or diagnose. Reported-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Cc: qemu-stable@nongnu.org Signed-off-by: Fam Zheng <famz@redhat.com> Tested-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'qemu-ga.texi')
0 files changed, 0 insertions, 0 deletions