diff options
author | Igor Mammedov <imammedo@redhat.com> | 2016-03-01 10:40:48 +0100 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2016-03-11 14:55:15 +0200 |
commit | c9f4b77ad5783bd84bca4ab99d4b3d6ee61de01c (patch) | |
tree | e1d576700ca73345cf37500876c3f3a65047d7bf /qdict-test-data.txt | |
parent | fff4e48ed54cc39e5942921df91300646ad37707 (diff) |
pc-dimm: fix error handling in pc_dimm_check_memdev_is_busy()
If host_memory_backend_get_memory() were to return error and
NULL MemoryRegion, pc_dimm_check_memdev_is_busy() would crash
dereferencing NULL pointer in memory_region_is_mapped().
But if error is set and non NULL MemoryRegion is returned
then error_setg() will fail with "error already set" assertion
in error_setv()
To avoid above issues use typical error handling pattern
for property setters:
Error *local_error = NULL;
...
error_propagate(errp, local_err);
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'qdict-test-data.txt')
0 files changed, 0 insertions, 0 deletions