diff options
author | Daniel P. Berrange <berrange@redhat.com> | 2016-09-30 15:45:27 +0100 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2016-10-25 16:25:48 +0200 |
commit | b3db211f3c80bb996a704d665fe275619f728bd4 (patch) | |
tree | e34f0cc6f45319406df854423720c90ec8278324 /qapi | |
parent | ebfd93b6803acef1a799ef6c755500087e37496e (diff) |
qapi: rename *qmp-*-visitor* to *qobject-*-visitor*
The QMP visitors have no direct dependency on QMP. It is
valid to use them anywhere that one has a QObject. Rename them
to better reflect their functionality as a generic QObject
to QAPI converter.
This is the first of three parts: rename the files. The next two
parts will rename C identifiers. The split is necessary to make git
rename detection work.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Split into file and identifier rename, two comments touched up]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi')
-rw-r--r-- | qapi/Makefile.objs | 4 | ||||
-rw-r--r-- | qapi/qapi-clone-visitor.c | 2 | ||||
-rw-r--r-- | qapi/qobject-input-visitor.c (renamed from qapi/qmp-input-visitor.c) | 2 | ||||
-rw-r--r-- | qapi/qobject-output-visitor.c (renamed from qapi/qmp-output-visitor.c) | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/qapi/Makefile.objs b/qapi/Makefile.objs index 7ea4aebb00..33906ff321 100644 --- a/qapi/Makefile.objs +++ b/qapi/Makefile.objs @@ -1,5 +1,5 @@ -util-obj-y = qapi-visit-core.o qapi-dealloc-visitor.o qmp-input-visitor.o -util-obj-y += qmp-output-visitor.o qmp-registry.o qmp-dispatch.o +util-obj-y = qapi-visit-core.o qapi-dealloc-visitor.o qobject-input-visitor.o +util-obj-y += qobject-output-visitor.o qmp-registry.o qmp-dispatch.o util-obj-y += string-input-visitor.o string-output-visitor.o util-obj-y += opts-visitor.o qapi-clone-visitor.o util-obj-y += qmp-event.o diff --git a/qapi/qapi-clone-visitor.c b/qapi/qapi-clone-visitor.c index 0bb8216372..34086cbfc0 100644 --- a/qapi/qapi-clone-visitor.c +++ b/qapi/qapi-clone-visitor.c @@ -110,7 +110,7 @@ static void qapi_clone_type_str(Visitor *v, const char *name, char **obj, assert(qcv->depth); /* * Pointer was already cloned by g_memdup; create fresh copy. - * Note that as long as qmp-output-visitor accepts NULL instead of + * Note that as long as qobject-output-visitor accepts NULL instead of * "", then we must do likewise. However, we want to obey the * input visitor semantics of never producing NULL when the empty * string is intended. diff --git a/qapi/qmp-input-visitor.c b/qapi/qobject-input-visitor.c index 37a8e1f931..81da76cc36 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qobject-input-visitor.c @@ -14,7 +14,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" -#include "qapi/qmp-input-visitor.h" +#include "qapi/qobject-input-visitor.h" #include "qapi/visitor-impl.h" #include "qemu/queue.h" #include "qemu-common.h" diff --git a/qapi/qmp-output-visitor.c b/qapi/qobject-output-visitor.c index 9e3b67ce13..92c5b5b7bb 100644 --- a/qapi/qmp-output-visitor.c +++ b/qapi/qobject-output-visitor.c @@ -13,7 +13,7 @@ */ #include "qemu/osdep.h" -#include "qapi/qmp-output-visitor.h" +#include "qapi/qobject-output-visitor.h" #include "qapi/visitor-impl.h" #include "qemu/queue.h" #include "qemu-common.h" @@ -152,7 +152,7 @@ static void qmp_output_type_int64(Visitor *v, const char *name, int64_t *obj, static void qmp_output_type_uint64(Visitor *v, const char *name, uint64_t *obj, Error **errp) { - /* FIXME: QMP outputs values larger than INT64_MAX as negative */ + /* FIXME values larger than INT64_MAX become negative */ QmpOutputVisitor *qov = to_qov(v); qmp_output_add(qov, name, qint_from_int(*obj)); } |