diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-09-23 00:39:25 +0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-10-06 14:47:41 +0200 |
| commit | e64c75a9752c5d0fd64eb2e684c656a5ea7d03c6 (patch) | |
| tree | 73a31e827186c8cdda8fd12ae290bd92b5ef5b57 /qapi/qmp-input-visitor.c | |
| parent | a65b6f27ce65e2e4f771f69d549ffa455a4d543a (diff) | |
qmp: fix object-add assert() without props
Since commit ad739706bbadee49, user_creatable_add_type() expects to be
given a qdict. However, if object-add is called without props, you reach
the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type:
Assertion `qdict' failed.", because the qdict isn't created in this
case (it's optional).
Furthermore, qmp_input_visitor_new() is not meant to be called without a
dict, and a further commit will assert in this situation.
If none given, create an empty qdict in qmp to avoid the
user_creatable_add_type() assert(qdict).
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20160922203927.28241-2-marcandre.lureau@redhat.com>
Tested-by: Xiao Long Jiang <zxiaol@linux.vnet.ibm.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi/qmp-input-visitor.c')
0 files changed, 0 insertions, 0 deletions