diff options
| author | Markus Armbruster <armbru@redhat.com> | 2017-04-26 09:36:41 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2017-05-09 09:14:40 +0200 |
| commit | bd269ebc82fbaa5fe7ce5bc7c1770ac8acecd884 (patch) | |
| tree | 82ef0cd9da0812afc7021d5690c14f72e8e13177 /qapi-schema.json | |
| parent | 62cf396b5d397948c5ac4d04d09596ca14f6c173 (diff) | |
sockets: Limit SocketAddressLegacy to external interfaces
SocketAddressLegacy is a simple union, and simple unions are awkward:
they have their variant members wrapped in a "data" object on the
wire, and require additional indirections in C. SocketAddress is the
equivalent flat union. Convert all users of SocketAddressLegacy to
SocketAddress, except for existing external interfaces.
See also commit fce5d53..9445673 and 85a82e8..c5f1ae3.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1493192202-3184-7-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[Minor editing accident fixed, commit message and a comment tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi-schema.json')
| -rw-r--r-- | qapi-schema.json | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/qapi-schema.json b/qapi-schema.json index eab41396e1..5728b7f363 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4126,7 +4126,11 @@ # # Captures the address of a socket, which could also be a named file descriptor # -# Note: This type is deprecated in favor of SocketAddress. +# Note: This type is deprecated in favor of SocketAddress. The +# difference between SocketAddressLegacy and SocketAddress is that the +# latter is a flat union rather than a simple union. Flat is nicer +# because it avoids nesting on the wire, i.e. that form has fewer {}. + # # Since: 1.3 ## @@ -4154,14 +4158,11 @@ ## # @SocketAddress: # -# Captures the address of a socket +# Captures the address of a socket, which could also be a named file +# descriptor # # @type: Transport type # -# This is just like SocketAddressLegacy, except it's a flat union rather -# than a simple union. Nicer because it avoids nesting on the wire, -# i.e. this form has fewer {}. -# # Since: 2.9 ## { 'union': 'SocketAddress', |